Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bottom margin to included code output #687

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

nhirschey
Copy link
Collaborator

Addresses issue raised here #686

@dsyme
Copy link
Contributor

dsyme commented Jul 22, 2021

Thanks!

@dsyme dsyme merged commit d454936 into fsprojects:master Jul 22, 2021
@dsyme
Copy link
Contributor

dsyme commented Jul 22, 2021

@nhirschey I think @gbaydin has recently made some more improvements to DiffSharp CSS, we should trial them for incorporation back into here

@gbaydin
Copy link
Contributor

gbaydin commented Jul 22, 2021

I can send a quick PR with the latest one I'm quite happy with.

@dsyme
Copy link
Contributor

dsyme commented Jul 22, 2021

Yes please do if you have time, @nhirschey if you could review, trial and compare that would be great

@gbaydin please copy back any recent changes line by line rather than wholesale, the CSS wasn't completely aligned

@gbaydin gbaydin mentioned this pull request Jul 22, 2021
@nhirschey
Copy link
Collaborator Author

Sure, I'm happy to review and compare. I like the diffsharp style. So far this is the only style "regression" that I noticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants